[FFmpeg-devel] [PATCH]Silence a msvc warning

Ronald S. Bultje rsbultje at gmail.com
Wed Sep 19 00:04:10 CEST 2012


On Tue, Sep 18, 2012 at 9:53 AM, Hendrik Leppkes <h.leppkes at gmail.com> wrote:
> On Tue, Sep 18, 2012 at 6:40 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>> Derek Buitenhuis <derek.buitenhuis <at> gmail.com> writes:
>> > On 18/09/2012 12:17 PM, Carl Eugen Hoyos wrote:
>> > > msvc currently often warns:
>> > > warning C4554: '>>' : check operator precedence for possible error; use
>> > > parentheses to clarify precedence
>> >
>> > This is rather dumb indeed. Patch looks OK to me.
>> Patch applied.
>> I found another one that I suspect you want to silence:
>> libavcodec\get_bits.h(255) : warning C4189: 're_size_plus8' :
>> local variable is initialized but not referenced
>> If you agree, I will commit a patch.
>> Thank you, Carl Eugen
> Arbitrarily disabling warnings just because they show up a lot is not a
> solution to any problem.
> This variable in particular is marked av_unused, which apparently is just
> void for MSVC, so instead try to find a way to make av_unused work, instead
> of disabling the whole warning, eventually hiding real warnings.

+1 on this, please don't disable all warnings. Unused variables can be
a real problem, we don't want to hide them altogether.

I'm delighted to see all this sudden interest in MSVC support, though.
Kudos, guys.


More information about the ffmpeg-devel mailing list