[FFmpeg-devel] [PATCH] mingw: Use avprive_vsnprintf in bprint

Derek Buitenhuis derek.buitenhuis at gmail.com
Thu Sep 20 21:13:21 CEST 2012

On 20/09/2012 12:51 PM, Nicolas George wrote:
> This looks strange: why do you not proceed the same way as for the basic
> version of this file, i.e.
> OBJS-$(HAVE_MINGW32) += ../compat/msvcrt/snprintf.o
> bprint is not the only place where vsnprintf is used. If mingw's
> implementation is bogus, it may be better to get the fixed version used by
> the whole library.

Since it should then be used by both MinGW & MSVC, we run into some design

- Where do we include/put the function prototypes?
- Do we keep using -D?
- Is there a HAVE_* that covers both? Perhaps HAVE_MSVCRT can.
- Do we want to use MinGW's own vsnprintf if the version is new enough>

- Derek

More information about the ffmpeg-devel mailing list