[FFmpeg-devel] [PATCH] lavf/oggdec: check for begin-of-stream flag in case of chained streams.

Alexander Strasser eclipse7 at gmx.net
Fri Sep 21 23:54:27 CEST 2012

Hi Clément,

Clément Bœsch wrote:
> Fix Ticket #1617, revealing a regression I introduced in 8f3eebd.
> ---
> diff --git a/libavformat/oggdec.h b/libavformat/oggdec.h
> index aa94db5..b68c40d 100644
> --- a/libavformat/oggdec.h
> +++ b/libavformat/oggdec.h
> @@ -76,6 +76,7 @@ struct ogg_stream {
>      int page_end;   ///< current packet is the last one completed in the page
>      int keyframe_seek;
>      int got_start;
> +    int got_data;   ///< 1 if the stream expected some data (non-initial packets), 0 otherwise

  I am really not familiar with the ogg code. But this comment does not
match the variable name. It seems a bit odd that a boolean variable named
got_<something> is true if "the stream expected some data".

  This is not important for the technical side of the patch, and thus you
can safely ignore it for now and wait until someone with more knowledge of
that code acks/reviews your patch.



More information about the ffmpeg-devel mailing list