[FFmpeg-devel] [PATCH] mingw: Use avprive_vsnprintf in bprint

Ronald S. Bultje rsbultje at gmail.com
Sat Sep 22 00:34:54 CEST 2012


On Fri, Sep 21, 2012 at 2:54 PM, jamal <jamrial at gmail.com> wrote:
> Why is that some people don't like the idea of a header that gets included only in the files that need this, anyway? For vnsprintf it would be nine files, and there's no need to do it for snprintf since MSVC can use -D instead of function prototypes.
> Globally forcing the inclusion of a header from the command line is really ugly.

Because it's also really ugly to include a custom header that - if you
follow the standard - shouldn't be necessary. It leads to
easy-to-occur accidents where new files using vsnprintf() get added by
someone coding on a C99-compliant system, forgets to include the
header, commits it, and either introduces a compile failure on systems
that do need the compat header, or worse, introduces security issues
on these systems alone (5% of our developers use it; 95% of our users
use it).


More information about the ffmpeg-devel mailing list