[FFmpeg-devel] [PATCH] lavc/mmvideo: fix potential buffer overread in mm_decode_pal()

Stefano Sabatini stefasab at gmail.com
Mon Sep 24 15:01:07 CEST 2012

On date Wednesday 2012-07-25 12:36:11 +0000, Paul B Mahol encoded:
> On 7/25/12, Stefano Sabatini <stefasab at gmail.com> wrote:
> > Add missing buffer check.
> 1: that check is not missing (in security sense).
> 2: why you are checking this in for loop?
> 3: if you are checking for left bytes why you are checking it again in
> call bellow using checked bytestream2 function
> (bytestrean2_get_be24())?
> 4: commit message is incorrect.

Better fix by Nicolas applied. Patch dropped.
FFmpeg = Faithless and Foolish Mystic Porn Efficient Game

More information about the ffmpeg-devel mailing list