[FFmpeg-devel] [PATCH 1/2] Move xGA font data from lavc to lavu.
ubitux at gmail.com
Tue Sep 25 10:06:58 CEST 2012
On Tue, Sep 25, 2012 at 09:53:11AM +0200, Stefano Sabatini wrote:
> On date Saturday 2012-09-22 10:16:01 +0200, Clément Bœsch encoded:
> > This needs to be accessible for libavfilter in the next commit.
> > TODO:
> > - lavu minor bump
> > ---
> > libavcodec/ansi.c | 13 +-
> > libavcodec/bintext.c | 5 +-
> > libavcodec/cga_data.c | 391 +------------------------------------------
> > libavcodec/cga_data.h | 3 +-
> > libavcodec/tmv.c | 3 +-
> > libavutil/Makefile | 1 +
> > libavutil/xga_font_data.c | 417 ++++++++++++++++++++++++++++++++++++++++++++++
> > libavutil/xga_font_data.h | 34 ++++
> > 8 files changed, 466 insertions(+), 401 deletions(-)
> > create mode 100644 libavutil/xga_font_data.c
> > create mode 100644 libavutil/xga_font_data.h
> Uhm you're moving the data but not the interface which manipulates
> those data, any special reason for that?
Yes, I didn't see any potential usage for the palettes and the function
outside of lavc: I just wanted a table of characters for easy printing in
Also, I'm using avpriv_ so it's limited to usage within the project. Maybe
a potential external usage would be for an OSD or something like this, but
until someone really wants it I don't see the point in exporting these
> When this is clarified, I'm in favor of this patch, I would be even
> happier if someone could clarify the use of the API (e.g. by extending
> its doxy).
Not sure that's really worth for an internal table but well.
> Also, from my understanding we now are supporting these classes of
> global symbols:
> av*: public symbols
> avpriv*: symbols which can be used within the libav* libraries
> (e.g. is defined in libavfoo and can be called from libavbar), but
> should not be used externally
> ff*: symbols internal to a libav* library, which should not be
> referenced by other libav* libraries or by external applications
> Am I correct?
AFAICT you are.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 490 bytes
Desc: not available
More information about the ffmpeg-devel