[FFmpeg-devel] [PATCH] ffprobe: generalize writer subsection nesting model

Stefano Sabatini stefasab at gmail.com
Wed Sep 26 11:11:31 CEST 2012

On date Wednesday 2012-09-26 01:07:18 +0200, Stefano Sabatini encoded:
> On date Tuesday 2012-09-25 21:39:00 +0200, Clément Bœsch encoded:
> > OK, that's kind of a huge patch. I'll hardly be able to make a deeper
> > review. Feel free to drop any of my comments if you plan to fix them in a
> > later patch, and if passes FATE.
> > 
> > Just an extra check before you push, I'm always a bit worried about stuff
> > like a missing trailing comma in the json output in some corner cases,
> > like when you have metadata but empty, or no metadata at all (and so the
> > section is not printed).  Also when you mixed try various different
> > combinations of the -show_* options.
> > 
> > Anyway, good work so far, thanks.
> I'll do more tests, and push when I feel the patch can be considered
> ready.

FFmpeg = Fundamentalist and Free Most Portentous Enlightening Gem

More information about the ffmpeg-devel mailing list