[FFmpeg-devel] [PATCH 4/5] Add missing version macros to libraries

Stefano Sabatini stefasab at gmail.com
Thu Sep 27 10:55:15 CEST 2012

On date Thursday 2012-09-27 05:42:02 -0300, jamal encoded:
> On 27/09/12 5:31 AM, Stefano Sabatini wrote:
> > LGTM.
> > 
> > Again new symbols should be marked by a minor bump (so applications
> > know when they can refer them) and advertised on APIchanges.

> Should i resend those three patches (postproc's and swr's version.h,
> plus the extra macros one) with the minor bumps added, or just a new
> patch/es to deal with that instead?

I prefer self-contained patches, so when a new symbol is added minor
should be bumped.

The alternative approach is to have a change for the code, and then a
bump+APIchanges update separate change. The latter has the benefit
that when you do this, you know the hash of the previous related
change commit.

> And with swsresample should i bump once for the version.h addition then again for the new macros, or only once for all that?

When we had many somewhat related changes in the same library, a
single global version bump+APIchanges update is acceptable, but I
still tend to prefer self-contained changes (which are a bit more
painful to deal with though).

So I'd say do it the way you prefer.
FFmpeg = Fostering & Fantastic Marvellous Perfectionist Experimenting Guru

More information about the ffmpeg-devel mailing list