[FFmpeg-devel] [PATCH] opt: implement av_opt_set_from_string().

Nicolas George nicolas.george at normalesup.org
Sun Sep 30 10:26:21 CEST 2012

Le jour du Labour, an CCXX, Stefano Sabatini a écrit :
> Nit: @return on a separate line


> Nit: "No option name *found* near..."

I find that wording rather less natural.

> Nit+: key-value pairs


> Nit: "options" => "option names"


> I still believe this should be a general requirement for option names,
> so that using this function for parsing options will be painless,
> since the user was already aware of the limitations for option names
> when she creates the options in the first place (rather than having to
> tweak them later).
> Also we may set a limitation on the maximum option name length,
> controlled by a macro.

I agree, but documenting options names is beyond the scope of this
particular patch.

>			 Alternatively we may remove the lenght
> limitation entirely, and handle a dynamically allocated buffer in
> get_key().

I do not think it would be necessary, but it could be added later anyway.

> Looks fine otherwise.

Thanks. Finally pushed, with a little quack.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120930/583eae9b/attachment.asc>

More information about the ffmpeg-devel mailing list