[FFmpeg-devel] [PATCH 1/2] lavu/opt: add AV_OPT_TYPE_DURATION.

Nicolas George nicolas.george at normalesup.org
Mon Apr 1 17:58:24 CEST 2013

Le sextidi 6 germinal, an CCXXI, Michael Niedermayer a écrit :
> I dont think macros that break common grep use are a good idea

I agree this is a drawback I had not anticipated, but it should be weighted
against the benefits: this macro system makes the options much more
readable, IMHO (see its use in asrc_sine.c). I will submit to the majority
opinion on that.

(Arguably, "grep AV_OPT_TYPE_DURATION" finding only places where
AV_OPT_TYPE_DURATION is actually used in the code without being polluted by
all the options definitions could be considered a plus; "grep 'OPT.*DUR'"
will always find all occurrences.)


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130401/de5d3224/attachment.asc>

More information about the ffmpeg-devel mailing list