[FFmpeg-devel] [PATCH 1/2] lavc: do not init frame with guessed layout.

Michael Niedermayer michaelni at gmx.at
Mon Apr 1 20:30:15 CEST 2013

On Mon, Apr 01, 2013 at 07:42:26PM +0200, Nicolas George wrote:
> Le duodi 12 germinal, an CCXXI, Michael Niedermayer a écrit :
> > somewhat off topic but maybe guess layout max could be moved from
> > ffmpeg to libavcodec
> Apart from this line, that was merged from the fork only recently and that
> is clearly bogus (frame->channel_layout != avctx->channel_layout), lavc does
> not do any guessing. I think this is the best choice: simple, no surprise.
> (There are just two other uses of av_get_default_channel_layout() in lavc,
> both of them seem obsolete, and one of them is probably unreachable with
> normal API use; I will look into them more carefully when time permits.)
> With this considerations, patch ok?

some or maybe most user applications will need code to support some
stereo and mono files then

if(channel_count == 1 && channel_layout==unknown)
    channel_layout = mono

if(channel_count == 2 && channel_layout==unknown)
    channel_layout = stereo


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130401/6d120552/attachment.asc>

More information about the ffmpeg-devel mailing list