[FFmpeg-devel] [PATCH] lavu/opencl: apply misc cosmetics fixes

Derek Buitenhuis derek.buitenhuis at gmail.com
Mon Apr 1 23:02:31 CEST 2013


On 2013-04-01 7:55 AM, Stefano Sabatini wrote:
> Split long lines, reindent code, add missing spaces between operators,
> remove possibly confusing comment from av_opencl_buffer_read_image()
> doxy.
> ---
>  libavutil/opencl.c |  237 ++++++++++++++++++++++++++++------------------------
>  libavutil/opencl.h |   38 +++++----
>  2 files changed, 150 insertions(+), 125 deletions(-)

[...]


> -static const AVClass openclutils_class = {"OPENCLUTILS", av_default_item_name,
> -                                                   NULL, LIBAVUTIL_VERSION_INT,
> -                                                   offsetof(OpenclUtils, log_offset),
> -                                                   offsetof(OpenclUtils, log_ctx)};
> +static const AVClass openclutils_class = {
> +    "OPENCLUTILS", av_default_item_name,
> +    NULL, LIBAVUTIL_VERSION_INT,
> +    offsetof(OpenclUtils, log_offset),
> +    offsetof(OpenclUtils, log_ctx)
> +};

One per line is probably more readable, and using designated initializers even more so.

Rest OK.

- Derek


More information about the ffmpeg-devel mailing list