[FFmpeg-devel] [PATCH 1/2] lavc: do not init frame with guessed layout.

Michael Niedermayer michaelni at gmx.at
Wed Apr 3 18:34:41 CEST 2013

On Wed, Apr 03, 2013 at 05:50:39PM +0200, Nicolas George wrote:
> Le duodi 12 germinal, an CCXXI, Michael Niedermayer a écrit :
> > you still need av_get_default_channel_layout when
> > AVCodec.channel_layouts isnt set. Either way iam fine with it as long
> > as it works
> If this point of code is reached, that means that channel_layout = 0 is ok.
> This line is only there because the fork's AVFrame does not have a channels
> field, using the same kind of bad design you talked me out of three months
> ago (but without the excuse of trying to keep compatibility).
> Patch queued, can you pull this please?
> 79d8cfa lavfi: loop on request_frame if necessary.
> 69d67fb lavfi: reindent after last commit.
> 77fa554 lavfi/vf_tile: simplify request_frame loop.
> 9566ba9 lavfi/f_ebur128: remove request_frame hack.
> b570f24 lavfi/af_asetnsamples: simplify request_frame loop.
> d38c173 lavfi/af_atempo: simplify request_frame loop.
> 464f94b lavc: do not init frame with guessed layout.



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130403/31f0c748/attachment.asc>

More information about the ffmpeg-devel mailing list