[FFmpeg-devel] [PATCH]Either set both display_width and display_height to pixeLwidth and pixel_height or none

[Michael Niedermayer]

On Wed, Apr 03, 2013 at 10:12:54AM +0200, Hendrik Leppkes wrote:
> On Wed, Apr 3, 2013 at 10:06 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> 
> > Hi!
> >
> > Attached patch fixes ticket #2429 for me.
> >
> > Please comment, Carl Eugen
> >
> >
> According to the Matroska Spec, DisplayWidth/DisplayHeight have a default
> value of PixelWidth/PixelHeight respectively, so its perfectly valid to
> only encode one of them in the file to override only one.
> ie. i can imaging having a file with Pixel W/H of 1440x1080, and a
> DisplayWidth of 1920, giving a result of 1920x1080 for Display W/H, taking
> the default into account.
> 
> So the current code appears correct.

yes, but the file is not valid, it seems to store a 0 display width
not "no value" 

I changed the code to handle such 0 display width better, please flame
me if i missed some issue with it!


> 
> The one limitation to this rule is that the defaults only apply if
> DisplayUnit has the value 0, which is not checked by avformat, maybe this
> is the case here?
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130404/9a671039/attachment.asc>