[FFmpeg-devel] [PATCH 2/9] SBR DSP x86: implement SSE qmf_deint_neg

Christophe Gisquet christophe.gisquet at gmail.com
Fri Apr 5 15:43:10 CEST 2013

2013/4/5 Michael Niedermayer <michaelni at gmx.at>:
> On Thu, Apr 04, 2013 at 07:45:46PM +0000, Christophe Gisquet wrote:
>> No vector tests it.
> No fate vector? or
> this code is completely untested ?

Yes, no fate vector indeed. I didn't look up any vector that may have
been provided by a standardization body.

> I tried a few files i had on my disk but it seems i dont have
> any that uses this code ...

Same here, even using files I think encoded by either Quicktime or Nero.

> If noone has any file that uses this then optimizing it would also
> not speed any files up.

Indeed, it's just that it was part of the dsp functions, and I
implemented before seeing it wasn't used. And so, it isn't validated

So indeed, the patch is unneeded, as well as dsp implementations of
this function.


More information about the ffmpeg-devel mailing list