[FFmpeg-devel] [PATCH] lavfi: remove noise libmpcodecs wrapper

Paul B Mahol onemda at gmail.com
Sat Apr 6 18:27:25 CEST 2013

On 4/6/13, Paul B Mahol <onemda at gmail.com> wrote:
> On 4/6/13, Michael Niedermayer <michaelni at gmx.at> wrote:
>> On Fri, Apr 05, 2013 at 11:50:01PM +0000, Paul B Mahol wrote:
>>> Native filter have been implemented.
>>> Even with inline assembly manually enabled, this filter
>>> is significanly slower than native one.
>>> Optimization to native filter can be added at any time
>>> and there is no reason to keep mp filter just because
>>> it have inline assembly that gets never enabled.
>> noise=all_strength=30
>> 22863845 decicycles in noise, 32 runs, 0 skips
>> the filter shows artifacts (quality is IMHO not acceptable)
> What artifacts?
> You did not provide full command line (so i can make sure you tested
> same pixel format).
> The only difference is not using random().

And you are the one who proposed to replace random().
mp=noise still use it.

More information about the ffmpeg-devel mailing list