[FFmpeg-devel] [PATCH] dfa: implement tdlt chunk decoding

Derek Buitenhuis derek.buitenhuis at gmail.com
Mon Apr 8 01:51:36 CEST 2013

On 2013-04-07 7:37 PM, Paul B Mahol wrote:
>>> I already have same line in code what
>>> Michael sent in his reply
>> What does that matter?
>>> So to not come to similar situation again, I should reply to
>>> every your review with new patch until I get explicit approval?
>> Not necessarily with an new patch. How about we start with replying
>> /at all/ instead of saying nothing to address the review, and pushing
>> regardless. That's a dick move.
> If what was commited did not address your review, I'm all ears for
> solution.

The proper solution is to not rely on frame subtraction here, but keep
a counter.

Consider when segments is 0xFFFFFFFF, and count and skip always end up 0xFF.
This could be a crafted stream, for example.

Also, the point is not that "it addressed the review". This is not just a
technical complaint. It is a social complaint. Now, I know decent social
interaction practices are pretty frowned upon in the FFmpeg community, but
I think a baseline of basic decency like "don't completely ignore someone's
review email" is kind of essential for any sort of collaborative environment.
Just because you "addressed the problem elsewhere" does excuse one from the
basic social contract of acknowledgement (Read: Not being a dickbag).

- Derek

More information about the ffmpeg-devel mailing list