[FFmpeg-devel] [PATCH] lavfi/mandelbrot: fix speedloss with default config after morphing introduction.

Derek Buitenhuis derek.buitenhuis at gmail.com
Mon Apr 8 20:24:59 CEST 2013

On 2013-04-08 2:14 PM, Michael Niedermayer wrote:
> On Mon, Apr 08, 2013 at 02:11:24PM -0400, Derek Buitenhuis wrote:
>> On 2013-04-08 2:06 PM, Paul B Mahol wrote:
>>> I think it disables code which result will never be used.
>> Should be added to the message then, to prevent moments of
>> "I think" in the future.
> If you want such full and extensive docs then you can also write
> that ? : style was tried (as it would be simpler) but it didnt fix
> the speed regression

I'd hardly call "write down why this was done" or "what was done" in
the commit message is "full and extensive documentation". In fact, it's
the bare minimum.

Stuff like:

"fix bug"


"add speed"

are 100% useless commit messages. Why bother having one at all?

This is why fixing bugs in FFmpeg is painful. Hardly any changes have any reason
given, or even an explanation.

- Derek

More information about the ffmpeg-devel mailing list