[FFmpeg-devel] [PATCH] video stabilization plugins using vid.stab library

[compn]

On Sun, 14 Apr 2013 22:06:36 +0200, Clément Bœsch wrote:
>On Sun, Apr 14, 2013 at 09:58:20PM +0200, Georg Martius wrote:
>> Hi,
>> 
>> On Sunday 14 April 2013 13:00:54 Clément Bœsch wrote:
>> [...]
>> > 
>> > Your patch was not rebased on the master since a long time, so we can't
>> > apply it. Additionally, some recent changes in libavfilter will require
>> > some little adjustments in your filters...
>> > 
>> Little adjustments are well put....
>> I don't understand the new options system and I don't see at the moment how it 
>> can be implemented with my library.
>
>> When exactly are the options processed and the values set? It is before init 
>> is called right?
>
>Yes it's before init.
>
>> But what if the filter needs to initialize something before the option values 
>> are written.
>
>You can't. Actually, if you need to do that, you might have a design
>issue.
>
>> Also I found it weird to not see any reference of the filterXX_options variable 
>> again in the code. Too much magic going on...
>
>You should look at similar filters and use them as reference. The idea is
>to have an AVOption array, and set the priv_class in the AVFilter
>declaration.

could you show him by converting one of his options to avoptions?
it may help him fix his code...

-compn