[FFmpeg-devel] [PATCH 1/2] colorbalance filter

Stefano Sabatini stefasab at gmail.com
Wed Apr 17 00:42:35 CEST 2013


On date Tuesday 2013-04-16 22:27:10 +0000, Paul B Mahol encoded:
> On 4/16/13, Stefano Sabatini <stefasab at gmail.com> wrote:
> > On date Tuesday 2013-04-16 12:23:30 +0000, Paul B Mahol encoded:
[...]
> >> +    cb->nb_components = av_get_padded_bits_per_pixel(desc) >> 3;
> >
> > pixdesc->nb_components, the formula is wrong (even if it produces the
> > pixdesc->expected result)
> 
> Not for RGB0 and others ....

Then please use a meaningful name, "pixel_step" could be an option.
-- 
FFmpeg = Fancy Foolish Mythic Patchable Experimenting Geisha


More information about the ffmpeg-devel mailing list