[FFmpeg-devel] [PATCH] examples/filtering_audio: get rid of AVABufferSinkParams

[Michael Niedermayer]

On Wed, Apr 17, 2013 at 12:46:49AM -0600, pkoshevoy at gmail.com wrote:
> From: Pavel Koshevoy <pkoshevoy at gmail.com>
> 
> AVABufferSinkParams are ignored by avfilter_graph_create_filter,
> therefore the example is misleading.  Use av_opt_set_int_list to
> configure abuffersink directly.

applied

> 
> Also, make the example a bit more interesting.

i didnt apply that part because it seems theres some bug somewhere,
possibly in the atempo filter:

==27906== Invalid read of size 2
==27906==    at 0x460463: print_frame (filtering_audio.c:192)
==27906==    by 0x460706: main (filtering_audio.c:253)
==27906==  Address 0xc5e9d40 is 0 bytes after a block of size 1,280 alloc'd
==27906==    at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
==27906==    by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
==27906==    by 0xB73D6F: av_malloc (mem.c:93)
==27906==    by 0xB68737: av_buffer_alloc (buffer.c:70)
==27906==    by 0x461A28: ff_default_get_audio_buffer (audio.c:57)
==27906==    by 0x4A84AC: filter_frame (af_atempo.c:1073)
==27906==    by 0x4642A1: ff_filter_frame_framed (avfilter.c:917)
==27906==    by 0x466310: ff_filter_frame (avfilter.c:990)
==27906==    by 0x4A5952: filter_frame (af_aresample.c:207)
==27906==    by 0x4642A1: ff_filter_frame_framed (avfilter.c:917)
==27906==    by 0x466310: ff_filter_frame (avfilter.c:990)
==27906==    by 0x469E91: request_frame (buffersrc.c:487)
==27906==
==27906== Invalid read of size 2
==27906==    at 0x460484: print_frame (filtering_audio.c:193)
==27906==    by 0x460706: main (filtering_audio.c:253)
==27906==  Address 0xc5e9d40 is 0 bytes after a block of size 1,280 alloc'd
==27906==    at 0x4C2A6C5: memalign (vg_replace_malloc.c:727)
==27906==    by 0x4C2A760: posix_memalign (vg_replace_malloc.c:876)
==27906==    by 0xB73D6F: av_malloc (mem.c:93)
==27906==    by 0xB68737: av_buffer_alloc (buffer.c:70)
==27906==    by 0x461A28: ff_default_get_audio_buffer (audio.c:57)
==27906==    by 0x4A84AC: filter_frame (af_atempo.c:1073)
==27906==    by 0x4642A1: ff_filter_frame_framed (avfilter.c:917)
==27906==    by 0x466310: ff_filter_frame (avfilter.c:990)
==27906==    by 0x4A5952: filter_frame (af_aresample.c:207)
==27906==    by 0x4642A1: ff_filter_frame_framed (avfilter.c:917)
==27906==    by 0x466310: ff_filter_frame (avfilter.c:990)
==27906==    by 0x469E91: request_frame (buffersrc.c:487)
==27906==
==27906== Syscall param write(buf) points to uninitialised byte(s)
==27906==    at 0xAF72900: __write_nocancel (syscall-template.S:82)
==27906==    by 0xAF05882: _IO_file_write@@GLIBC_2.2.5 (fileops.c:1289)
==27906==    by 0xAF05749: new_do_write (fileops.c:543)
==27906==    by 0xAF06EB4: _IO_do_write@@GLIBC_2.2.5 (fileops.c:516)
==27906==    by 0xAF05DBF: _IO_file_sync@@GLIBC_2.2.5 (fileops.c:918)
==27906==    by 0xAEFACFA: fflush (iofflush.c:43)
==27906==    by 0x4604BB: print_frame (filtering_audio.c:196)
==27906==    by 0x460706: main (filtering_audio.c:253)
==27906==  Address 0x40244c4 is not stack'd, malloc'd or (recently) free'd
==27906==

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130417/2318c212/attachment.asc>