[FFmpeg-devel] [PATCH] Fix multithreaded MPEG-4 decoding.

[Hendrik Leppkes]

On Thu, Apr 18, 2013 at 8:57 PM, Michael Niedermayer <michaelni at gmx.at>wrote:

> On Thu, Apr 18, 2013 at 07:13:56PM +0200, Reimar Döffinger wrote:
> > Regression since c10d498bfd246a40cc7830838b74e18a79418839.
> > Unfortunately ff_thread_get_format can only be called from
> > a separate decode thread, running it during init will fail.
> > Fixes for that are welcome, for now just revert back to
> > calling avctx->get_format directly, which is correct
> > but having to decide on a case-by-case basis which approach
> > to use is a bit messy.
>
> not using get_format() for anything but getting the format would
> solve this mess, i mean no sideeffects like initializing some hardware
>
>
I agree, there are hacks upon hacks piling up to fix
hacky/bad implementations in players.
The way i see it, get_format should not be used to do anything but define
the format you want, and multi-threading should be disabled for hwaccel,
everything else is just a incredible maintenance burden to try to keep
functional in the long run.