[FFmpeg-devel] [PATCH 2/2] lavc: check decoded subtitles encoding.

Nicolas George nicolas.george at normalesup.org
Sun Apr 21 19:13:39 CEST 2013

Le duodi 2 floréal, an CCXXI, Clement Boesch a écrit :
> Not sure about the wording, possibly "The decoded subtitle line doesn't
> look like UTF-8 so the input character encoding need to be known for
> correct decoding (see -sub_charenc input option)\n".

More than two lines of text is too much for an error message, IMHO. The
error message points to the option name, the documentation for the option
should be enough to provide all necessary information.

> So if you don't have a build with iconv, you just can't decode it (ok,
> partially) anymore? I would be much more comfortable with a warning...

People ignore warnings. This is returning invalid data, and possibly
generating invalid, unusable files. I really think this should be considered
an error. People just need to install libiconv.

(I am not against providing a fallback implementation supporting just UTF-8
and ISO-8859-1, but I am not sure if this is a good idea.)


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130421/b7cb5cb4/attachment.asc>

More information about the ffmpeg-devel mailing list