[FFmpeg-devel] [PATCH] libavcodec: Do not return encoding errors when -sub_charenc_mode is do_nothing
nfxjfg at googlemail.com
Wed Aug 28 23:55:11 CEST 2013
On Wed, 28 Aug 2013 23:41:49 +0200
Nicolas George <nicolas.george at normalesup.org> wrote:
> Le primidi 11 fructidor, an CCXXI, Eelco Lempsink a écrit :
> > Signed-off-by: Eelco Lempsink <eml at tupil.com>
> > ---
> > libavcodec/utils.c | 15 ++++++++++-----
> > 1 file changed, 10 insertions(+), 5 deletions(-)
> This is not what « do nothing » is meant for. It is meant for situations
> where the muxer already did the job, and the check to ensure that the job
> was done properly is still relevant.
> If you want to bypass the check, please add a dedicated option, and clearly
> document that any application that uses it is misdesigned and will not work
> once the full recoding API is implemented.
I think we all agree that the _current_ API is somewhat misdesigned.
What speaks against a way to work around the faults of the current API?
Also, sorry for the second "+1" reply to Lempsink. I had the same
thought and reaction twice, which I find very funny.
More information about the ffmpeg-devel