[FFmpeg-devel] [PATCH] lavfi/volume: support all channel counts

Stefano Sabatini stefasab at gmail.com
Mon Dec 2 20:13:45 CET 2013


On date Monday 2013-12-02 19:53:52 +0100, Nicolas George encoded:
> Le duodi 12 frimaire, an CCXXII, Stefano Sabatini a écrit :
> > ---
> >  libavfilter/af_volume.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c
> > index cd24877..4d95476 100644
> > --- a/libavfilter/af_volume.c
> > +++ b/libavfilter/af_volume.c
> > @@ -101,7 +101,7 @@ static int query_formats(AVFilterContext *ctx)
> >          }
> >      };
> >  
> > -    layouts = ff_all_channel_layouts();
> > +    layouts = ff_all_channel_counts();
> >      if (!layouts)
> >          return AVERROR(ENOMEM);
> >      ff_set_common_channel_layouts(ctx, layouts);
> 
> Does it work? A quick glance at the code seems to indicate you need to
> eradicate "av_get_channel_layout_nb_channels(inlink->channel_layout);",
> otherwise it will either produce silence or not change the volume at all.

Updated, FATE passes here.
-- 
FFmpeg = Fundamentalist and Freak Magnificient Peaceless Exciting Gospel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-lavfi-volume-support-all-channel-counts.patch
Type: text/x-diff
Size: 1122 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131202/70793d98/attachment.bin>


More information about the ffmpeg-devel mailing list