[FFmpeg-devel] [PATCH] lavfi/showspectrum: display multiple channels in separate row

[Paul B Mahol]

On 2/2/13, Stefano Sabatini <stefasab at gmail.com> wrote:
> On date Friday 2013-02-01 17:28:24 +0100, Rudolf Polzer encoded:
>> On Fri, Feb 01, 2013 at 04:19:35PM +0000, Paul B Mahol wrote:
>> > On 2/1/13, Rudolf Polzer <divverent at xonotic.org> wrote:
>> > > The showspectrum filter gets multiple channel (any count) support.
>> > > Most
>> > > ideas here are from durandal_1707.
>> > >
>> > > Screenshots (temporary URL):
>> > > http://rm.sudo.rm-f.org/~xonotic/temp/ffmpeg-showspectrum/screenshots/
>> > >
>> > > New options:
>> > >
>> > > - combined=1: old ffplay-like combined view of all channels
>> > > - intensity=1: sox-like intensity spectrum
>> > > - logscale=1: sox-like logarithmic scale
>> > > - saturation=<float>: saturation modifier
>> >
>> > If there are no objections i will commit this but with different
>> > logic in options and updated doxy:
>> >
>> > mode: combined, separate
>>
>> sure
>>
>> > ???: intensity
>>
>> color=intensity, color=channel, color=gray (latter would be kinda
>> redundant with saturation=0, but who cares)
>>
>> > scale: logarithmic, square root
>>
>> A bit long... maybe scale=log, scale=sqrt (and maybe scale=lin too?
>> didn't look very useful when I tried it, though...)
>>
>> Will you do these changes? They certainly are fine by me.
>
> +1 on the PBM suggestions.

Please, I do not call you SS. (I not gonna spend 10 hours on your
                               preffered review process which is
                               extremly daunting and boring just
                               to get into new round by 50 seconds
                               review)

>
> Please guys send an updated patch, so I get a chance to comment on
> syntax/doc/code.

What? Syntax and doc should be trivial. Code you could already review
& comment 10 times.

>
> [...]
> --
> FFmpeg = Fanciful & Foolish Meaningless Picky Enlightened Glue
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>