[FFmpeg-devel] [PATCH 9/9] ffplay: add -af option

[Stefano Sabatini]

On date Sunday 2013-02-03 16:30:11 +0100, Stefano Sabatini encoded:
[...]
> Updated work in progress.
> 
> I'm not sure about how to handle configuration in open_audio(). Right
> now I'm configuring the filtergraph, *then* opening the audio device.
> 
> In order to minimize changes, in audio_decode_frame() (which should be
> renamed something like audio_process_frame) I'm passing is->frame to
> the filtergraph, and I convert it back to is->frame if I manage to get
> a frame. Then the data is handled the usual way.
> 
> In case the device target configuration differs from the output
> filter, the normalization code in audio_decode_frame() should convert
> it to the target configurations (possibly not very efficient).
> Alternatively: we configure the filters, open the device, then
> *reconfigure* the filters to take into account of the device
> configuration (and virtually avoids the need for the output
> normalization).
> 
> The current design doesn't address the case where the input changes,
> which should be addressed by either reconfiguring the filtergraph or
> adding another normalization layer between the decoder and the
> filtergraph.

Updated.

This one solves all the above mentioned problems, but it is currently
skipping sample compensation. The only approach I can see is to use a
dedicated swr context for that.

Not yet ready for commit, but feel free to comment.
-- 
FFmpeg = Free and Fundamentalist Multimedia Portable Enhancing Gem
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-ffplay-add-af-option.patch
Type: text/x-diff
Size: 12949 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130203/29f353bf/attachment.bin>