[FFmpeg-devel] [PATCH]Refuse to mux some real codecs into mkv

Paul B Mahol onemda at gmail.com
Sat Feb 9 23:12:11 CET 2013


On 2/9/13, Paul B Mahol <onemda at gmail.com> wrote:
> On 2/9/13, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>> Paul B Mahol <onemda <at> gmail.com> writes:
>>
>>> > The muxing is still broken and I cannot fix it.
>>>
>>> I can fix this in 6 minutes.
>
> Well it appears out that fix would be less trivial
> than I hoped.
>
>>
>> Please do and consider my patch dropped.
>
> Are you sure that -codec copy between mkv ->mkv or rm->mkv
> does not work?
>
> (Obviously for mkv files not generated with ffmpeg,
>  which lack codec private data and some headers
>  per each packet)

Conclustion: feel free to push if it could not break
something that already worked like -codec copy. If
-codec copy works you would need to check there is
extradata present and if not abort.


More information about the ffmpeg-devel mailing list