[FFmpeg-devel] [PATCH 9/9] ffplay: add -af option

[Stefano Sabatini]

On date Saturday 2013-02-23 00:52:13 +0100, Marton Balint encoded:
> 
> On Fri, 22 Feb 2013, Stefano Sabatini wrote:
> 
> >On date Thursday 2013-02-21 20:28:33 +0100, Marton Balint encoded:
> >[...]
> >>On Tue, 5 Feb 2013, Marton Balint wrote:
> >>
> >>>>From b03a8a5c31dbf600bb55d8381bb5eeac0c0e91e1 Mon Sep 17 00:00:00 2001
> >>>>From: Stefano Sabatini <stefasab at gmail.com>
> >>>>Date: Sun, 3 Feb 2013 21:29:01 +0100
> >>>>Subject: [PATCH] ffplay: add -af option
> >>>>
> >>>>---
> >>>>doc/ffplay.texi |    6 ++
> >>>>ffplay.c        |  194
> >>>>+++++++++++++++++++++++++++++++++++++++++++++++++++----
> >>>>2 files changed, 188 insertions(+), 12 deletions(-)
> >>
> >>Stefano, were you able to work on this? If not, I may will have a
> >>little time to make the proposed changes if that's ok with you.
> >
> >Sure, I'm not likely to work on it on this weekend, so feel free to do
> >it (I'd like to finalize sox and ladspa wrappers just after this).
> 
> Okay, here is a new version, with the proposed changes. Some issues
> we still need to figure out:
> 

> - What about unknown channel layout? FFplay was able to play it, by
> using the default channel layout from the number of channels, now
> abuffer bails out with an error.

Unknown channel layouts should be supported since the recent work of
Nicholas, see for example:
01649c79c87cb8c12b2e7e5ab64b5ec4fd5e97ca

> - At the moment I can't specify the required sample rate to an audio
> buffersink. Is there a planned patch for that? Or we should use a
> separate aformat filter to force an output sample rate?

Yes I had it for the buffersink, I'm going to test and push soon (it
was already approved).

> - Something is not right with the auto inserted filters and ebur128,
> i suspect this is not an ffplay issue, rather an avfilter or
> ebur128. For example this generates a broken output:
> ffplay stereomusic.mp3 -af ebur128,aformat=channel_layouts=mono

Please create a ticket so we don't forget it.

> 
> Regards,
> Marton

> From 9a882739a367907ed08c0d866fd1546152f26917 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefasab at gmail.com>
> Date: Sun, 3 Feb 2013 21:29:01 +0100
> Subject: [PATCH] ffplay: add -af option
> 
> ---
>  doc/ffplay.texi |    6 ++
>  ffplay.c        |  190 +++++++++++++++++++++++++++++++++++++++++++++++++++----
>  2 files changed, 182 insertions(+), 14 deletions(-)

Please put your name, and mention "based on ..." with a link to the
thread.

[...]

I can't spot obvious errors, so should be good if reasonably tested,
but wait for the pending buffersrc fixes.
-- 
FFmpeg = Furious and Furious MultiPurpose Enchanting Ghost