[FFmpeg-devel] [PATCH] lavu: add escape API

[Nicolas George]

Le tridi 3 ventôse, an CCXXI, Stefano Sabatini a écrit :
> +enum AVEscapeMode {
> +    AV_ESCAPE_MODE_BACKSLASH, ///< Use backslash escaping.
> +    AV_ESCAPE_MODE_QUOTE    , ///< Use single-quote escaping.
> +};

I still do not like the fact that the user is forced to select a mode and
can not say "just escape the string whatever way (the best way)". Maybe just
add AV_ESCAPE_MODE_AUTO, and:

    if (mode == AV_ESCAPE_MODE_AUTO)
	mode = AV_ESCAPE_MODE_BACKSLASH; /* TODO: implement a heuristic */

?

The rest looks ok to me.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130226/f24f9806/attachment.asc>