[FFmpeg-devel] [PATCH] lavf: add data: URI scheme.

Nicolas George nicolas.george at normalesup.org
Tue Jan 1 15:51:00 CET 2013

Le sextidi 6 nivôse, an CCXXI, Stefano Sabatini a écrit :
> Nit add an introductory sentence to the example, like:
> For example, to convert a data uri with @command{ffmpeg}:


> Nit: No ',' delimiter in uri '%s'
> in order to provide some more context

I added "in URI", but not the URI itself, as ffmpeg prints it already (and
other applications have it in the context) and it is very long.

> > +            if (!memchr(opt, '/', next - opt)) /* basic validity check */
> > +                return AVERROR(EINVAL);
> missing error message

Forgot to address this one before sending: locally added:

                av_log(h, AV_LOG_ERROR, "Invalid content-type '%.*s'\n",
                       (int)(next - opt), opt);

> I suspect the code could be made more simpler with some pattern
> matching (sscanf).

I am not sure, and I find sscanf rather annoying when extending the code.

> Maybe an error message here in the impossible case in which decode
> fails.

It is not impossible. Added. I will also submit to fix the return code.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130101/eacffcd1/attachment.asc>

More information about the ffmpeg-devel mailing list