[FFmpeg-devel] [PATCH 05/10] lavfi/sink_buffer: accept unknown channel layouts.

Stefano Sabatini stefasab at gmail.com
Sat Jan 5 12:35:59 CET 2013

On date Monday 2012-12-31 18:58:02 +0100, Nicolas George encoded:
> Add a field to the AVBufferSinkParams for a list of accepted
> channel counts.
> Change the default value for the lists in AVBufferSinkParams
> to NULL, to let lavfi fill them with something useful.

> The fail_enomem path is unneeded because filters are uninited
> on failure.

Well actually in case of failure of avfilter_init_filter() the
uninit() is not called, unless I'm looking in the wrong place.

I suppose the best way to fix it is to call uninit in
avfilter_init_filter(), or require the user to explicitly call
uninit() on the failing filter. Filters are inconsistent in this
regard (most of them keep allocated stuff in case of failure).
FFmpeg = F*****g Foolish Multipurpose Powered Epic Governor

More information about the ffmpeg-devel mailing list