[FFmpeg-devel] [PATCH 05/10] lavfi/sink_buffer: accept unknown channel layouts.

Nicolas George nicolas.george at normalesup.org
Sat Jan 5 14:30:24 CET 2013

Le quintidi 15 nivôse, an CCXXI, Stefano Sabatini a écrit :
> mallocz?

Good idea.

> Nit++: spurious


> > +            av_log(ctx, AV_LOG_ERROR,
> > +                   "Conflicting all_channel_counts and list\n");
> I suggest:
> Conflicting all_channel_counts and list in buffer sink parameters struct. 

The context already gives us "in buffer sink", added "parameters".

> LGTM otherwise.

Thanks. New series incoming after FATE finishes.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130105/d4165ea9/attachment.asc>

More information about the ffmpeg-devel mailing list