[FFmpeg-devel] [PATCH] astenc: Add an option to set the loop flag

[Michael Niedermayer]

On Sat, Jan 05, 2013 at 11:35:38AM -0300, James Almer wrote:
> On 23/12/12 7:04 PM, James Almer wrote:
> > On second thought, since we're not going to use a flag AVOption I'll go with Hoyo's suggestion.
> > Adding a new integer AVOption for this doesn't make sense.
> > 
> > Regards.
> 
> Ping.
> 
> The line "avio_seek(pb, file_size, SEEK_END);" should be changed to SEEK_SET, or file_size to 0, 
> or the entire line removed altogether.
> I don't think it's worth sending a new patch just for that change, but if you prefer it that way 
> I'll do it.

I notice theres noone listed in MAINTAINERS for astenc.c
maybe you want to add yourself there ?

about the change/patch
patches need to be tested, patches need to be applied
I assume you tested the changed code, so posting it should be a
a few seconds work only.
Its simply a bad idea to take patches change them according to some
english description and then hope that this matches what someone else
tested ...
besides its work and we are all lazy

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130105/757e999e/attachment.asc>