[FFmpeg-devel] [PATCH] Megalux Frame muxer and demuxer

[Peter Ross]

On Mon, Dec 31, 2012 at 10:24:14AM +1100, Peter Ross wrote:
> On Sun, Dec 30, 2012 at 04:24:51PM +0000, Carl Eugen Hoyos wrote:
> > Peter Ross <pross <at> xvid.org> writes:
> > 
> > > +const AVCodecTag ff_frm_pix_fmt_tags[] = {
> > > +    { PIX_FMT_RGB555, 1 },
> > > +    { PIX_FMT_BGR32,  2 },
> > > +    { PIX_FMT_RGB24,  3 },
> > > +    { PIX_FMT_BGRA,   4 },
> > 
> > > +    { PIX_FMT_BGRA,   5 },
> > 
> > Only from looking at the hexdump of your uploaded sample:
> > Shouldn't this be BGR0 (at least for "5"?
> > Or is the sample meant to be completely transparent?
> 
> Well spotted. My bad, this was written before well befire we had BGR0.
> > 
> > [...]
> > 
> > > +static int frm_read_probe(AVProbeData *p)
> > > +{
> > > +    if (p->buf_size > 8 &&
> > > +        p->buf[0] == 'F' && p->buf[1] == 'R' && p->buf[2] == 'M' &&
> > > +        AV_RL16(&p->buf[4]) && AV_RL16(&p->buf[6]))
> > > +        return AVPROBE_SCORE_MAX;
> > 
> > I suspect MAX is too much for 24bit plus two of four bytes != 0.
> 
> Okay.

Demuxer applied. (The muxer does not have any practical reason for being,
so I am going not going to bother with that.)

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130106/97c089ca/attachment.asc>