[FFmpeg-devel] [PATCH] dec/developer: Add Valgrind / Address Sanitizer to the patch checklist

Michael Niedermayer michaelni at gmx.at
Sat Jan 12 17:53:29 CET 2013


On Sat, Jan 12, 2013 at 05:33:45PM +0100, Stefano Sabatini wrote:
> On date Saturday 2013-01-12 17:17:45 +0100, Michael Niedermayer encoded:
> > On Sat, Jan 12, 2013 at 04:45:55PM +0100, Stefano Sabatini wrote:
> > > On date Saturday 2013-01-12 16:28:27 +0100, Michael Niedermayer encoded:
> > > > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > > > ---
> > > >  doc/developer.texi |    3 +++
> > > >  1 file changed, 3 insertions(+)
> > > > 
> > > > diff --git a/doc/developer.texi b/doc/developer.texi
> > > > index 7e4b12c..0439a50 100644
> > > > --- a/doc/developer.texi
> > > > +++ b/doc/developer.texi
> > > > @@ -507,6 +507,9 @@ send a reminder by email. Your patch should eventually be dealt with.
> > > >      Make sure you check the return values of function and return appropriate
> > > >      error codes. Especially memory allocation functions like @code{av_malloc()}
> > > >      are notoriously left unchecked, which is a serious problem.
> > > > + at item
> > > > +    Test your code with valgrind and or Address Sanitizer to ensure its free
> 
> its => it's

fixed


> 
> > > 
> > > Also specify the name of the tool, so that it's clear what "Address
> > > Sanitizer" refers to.
> > 
> > iam not sure i understand, it is called Address Sanitizer
> 
> Test your code with @command{valgrind} and/or Address Sanitizer
> (@command{asan}) to ensure it's free ...

not changed after discussion on IRC

applied
thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130112/587f4317/attachment.asc>


More information about the ffmpeg-devel mailing list