[FFmpeg-devel] [PATCH] HTTP cookie support

Micah Galizia micahgalizia at gmail.com
Mon Jan 14 03:38:53 CET 2013


OK,

All nits addressed and I changed to the while instead of do ... it kind of
feels strange setting things to NULL and keeping an extra pointer around,
but it does cut down a few lines ... it also feels strange using a goto.
Documentation patch is the same, but I regenerated because I used `git
reset` to roll them both back and I wasn't sure if it'd affect `git am` on
your end.

Anyway, thanks for the review.

PS: is there a difference between "nit" and "Nit"?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add-HTTP-protocol-cookie-support.patch
Type: application/octet-stream
Size: 6409 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130113/9db31325/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-document-HTTP-protocol-cookie-support.patch
Type: application/octet-stream
Size: 1451 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130113/9db31325/attachment-0001.obj>


More information about the ffmpeg-devel mailing list