[FFmpeg-devel] [PATCH] h264: add 3 pixels below for subpixel filter wait position.

Michael Niedermayer michaelni at gmx.at
Wed Jan 16 01:35:08 CET 2013


On Tue, Jan 15, 2013 at 08:38:54AM -0800, Ronald S. Bultje wrote:
> From: "Ronald S. Bultje" <rsbultje at gmail.com>
> If the motion vector is at a subpixel position, we need 3 pixels below
> the motion vector's wholepel position available, not 2, since the MC
> filter is a sixtap filter for the hpel position, and then a bilin filter
> for the qpel position.
> This patch fixes highly irreproducible (0.1%) fate failures in frame 2
> and 4 of h264-conformance-cama2_vtc_b (e.g. first P-frame, first field,
> last line of MB x=40,y=2 and second field and last lines of MBs x=39-40,
> y=3). These used pre-loopfilter instead of post-loopfilter data because
> the await_progress() waited for one line too little in that field, and
> the motion vector of these particular MBs happened to align exactly to a
> position where that demonstrates the bug.


thanks, great work!

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130116/110e5c43/attachment.asc>

More information about the ffmpeg-devel mailing list