[FFmpeg-devel] [PATCH] lavfi: EBU R.128 irreg time, ch weights, skip LFE

Nicolas George nicolas.george at normalesup.org
Wed Jan 16 16:14:04 CET 2013

Le septidi 27 nivôse, an CCXXI, sedacca at comcast.net a écrit :
> This suggested patch is for Ticket #2144 "libavfilter ebur128
> loudness inaccuracy, irregular time interval, LFE interference".
> (1) Correct the time interval between logged data rows to the expected 
> value of 100 milliseconds by naming a new loop counter variable 
> to be distinct from loop counters for inner loops. 
> (2) Correct the recognition of channel layouts for good channel weight 
> in the loudness computation. 
> (3) Correct the advancement of a pointer to skip over LFE samples 
> as intended in the loudness computation.

Thanks for the patch. Clément, the author of f_ebur128, has said he would be
unavailable for about a month, that probably means you will have to wait
before your patch can be reviewed and applied.

If it can be done without too much trouble, please consider following Carl
Eugen's advice and split the patch into three separate patches, that would
make review easier.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130116/2fa399ed/attachment.asc>

More information about the ffmpeg-devel mailing list