[FFmpeg-devel] [PATCH] latmenc: Check for LOAS sync word

James Almer jamrial at gmail.com
Wed Jan 16 20:14:56 CET 2013

On 16/01/13 8:52 AM, Michael Niedermayer wrote:
> On Wed, Jan 16, 2013 at 05:43:03AM -0300, James Almer wrote:
>> On 15/01/13 10:34 PM, Michael Niedermayer wrote:
>>> you can check extradata
>>> as a sideeffect it would fix the crash
>>> with the right (well wrong) data the current patch not fix the crash
>> How about the attached patch? (It still needs reindentation)
>> If there's no extradata then the packet is either LOAS or ADTS, and it should be
>> used if it's the former or discarded if it's anything else.
>> This also prevents potential misdetection of raw packets as ADTS packets, since 
>> the check was on the first 3 bytes as well and without checking if there was any
>> extradata available.
> raw aac cant start with a 0xF? or 0xE? these would be end tags

In that case the ADTS check will behave the same as it used to.
It doesn't change the intended effects of this patch.


More information about the ffmpeg-devel mailing list