[FFmpeg-devel] [PATCH 2/4] lavc: include timebase in avcodec string at debug level.

[Michael Niedermayer]

On Thu, Jan 17, 2013 at 06:16:30PM +0000, Paul B Mahol wrote:
> On 1/17/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavcodec/utils.c |    6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> > index 8c0aa98..165b083 100644
> > --- a/libavcodec/utils.c
> > +++ b/libavcodec/utils.c
> > @@ -2121,6 +2121,12 @@ void avcodec_string(char *buf, int buf_size,
> > AVCodecContext *enc, int encode)
> >          }
> >          break;
> >      default:
> 
> really default?

yes, do you see a problem with that ?


> 
> > +        if (av_log_get_level() >= AV_LOG_DEBUG) {
> > +            int g = av_gcd(enc->time_base.num, enc->time_base.den);
> 
> Could this return 0 for g?

not for any files i tested but ill add a check

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130117/9f9420e2/attachment.asc>