[FFmpeg-devel] [PATCH] vf_fade: use AVPixFmtDescriptor to find out if pixel format have alpha

[Stefano Sabatini]

On date Friday 2013-01-18 15:14:39 +0000, Paul B Mahol encoded:
> Remove alpha_pix_fmts[].
> 
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  libavfilter/vf_fade.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/libavfilter/vf_fade.c b/libavfilter/vf_fade.c
> index f395fd8..5b7ebcb 100644
> --- a/libavfilter/vf_fade.c
> +++ b/libavfilter/vf_fade.c
> @@ -169,13 +169,6 @@ const static enum AVPixelFormat studio_level_pix_fmts[] = {
>      AV_PIX_FMT_NONE
>  };
>  
> -static enum AVPixelFormat alpha_pix_fmts[] = {
> -    AV_PIX_FMT_YUVA420P, AV_PIX_FMT_YUVA422P, AV_PIX_FMT_YUVA444P,
> -    AV_PIX_FMT_ARGB, AV_PIX_FMT_ABGR,
> -    AV_PIX_FMT_RGBA, AV_PIX_FMT_BGRA,
> -    AV_PIX_FMT_NONE
> -};
> -
>  static int config_props(AVFilterLink *inlink)
>  {
>      FadeContext *fade = inlink->dst->priv;
> @@ -185,7 +178,7 @@ static int config_props(AVFilterLink *inlink)
>      fade->vsub = pixdesc->log2_chroma_h;
>  
>      fade->bpp = av_get_bits_per_pixel(pixdesc) >> 3;
> -    fade->alpha = fade->alpha ? ff_fmt_is_in(inlink->format, alpha_pix_fmts) : 0;
> +    fade->alpha = fade->alpha ? pixdesc->flags & PIX_FMT_ALPHA : 0;

This could be changed to:
       fade->alpha &= pixdesc->flags & PIX_FMT_ALPHA;

LGTM anyway, thanks.
-- 
FFmpeg = Foolish & Forgiving Muttering Peaceless Ecumenical Gorilla