[FFmpeg-devel] [PATCH] matroskaenc: add codec_tag lists back.

Paul B Mahol onemda at gmail.com
Wed Jan 23 15:35:39 CET 2013


On 1/23/13, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Paul B Mahol <onemda <at> gmail.com> writes:
>
>> >> > You misunderstand the patch.
>> >>
>> >> Than please explain what exactly patch solves.
>> >
>> > Ticket #2169 (it's in Michael's original mail).
>>
>> Sorry, but that does not explain why tta and wavpack is in it.
>>
>> Wavpack does not need to be there at all.
>
> wavpack and tta remuxing is "supported" both before
> and after the patch. That the muxer should (maybe)
> refuse to mux them, is completely orthogonal to
> this patch that fixes a regression that has
> nothing to do with wavpack and tta.

Patch adds lines which are not needed. Also you do not explain
how patch fixes that bug at least it is not obvious to me.

>
> (And apart from the fact that this patch should not
> include unrelated problems: Removing tta and wavpack
> from the new table would of course not stop the muxer
> from muxing them.)

I never claimed that muxing works or does not work for
certain codec.
Do not put words in my mouth. Thanks.

Simply remove unneded lines.


More information about the ffmpeg-devel mailing list