[FFmpeg-devel] [PATCH]Refuse to mux TTA into mkv

[Michael Niedermayer]

On Thu, Jan 24, 2013 at 01:20:41AM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> Wavpack is not muxed correctly, but since it works with both vlc and lavf, 
> I don't think we should change it.
> 
> I tested a few other codecs, they appear to work fine.
> 
> Please comment, Carl Eugen

>  matroskaenc.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 7ac2ac6aa2b2c480d6eb86699fe0a84e51e34733  patchmkvtta.diff
> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
> index 0e522fe..56adaa8 100644
> --- a/libavformat/matroskaenc.c
> +++ b/libavformat/matroskaenc.c
> @@ -931,6 +931,13 @@ static int mkv_write_header(AVFormatContext *s)
>      if (!mkv->tracks)
>          return AVERROR(ENOMEM);
>  
> +    for (i = 0; i < s->nb_streams; i++)
> +        if (s->streams[i]->codec->codec_id == AV_CODEC_ID_TTA) {
> +            av_log(s, AV_LOG_ERROR, "The Matroska muxer does not yet support muxing %s\n",
> +                   avcodec_get_name(s->streams[i]->codec->codec_id));
> +            return AVERROR_PATCHWELCOME;
> +        }
> +

if our TTA in mkv cant be read and isnt compliant then LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130124/e96373a4/attachment.asc>