[FFmpeg-devel] [PATCH]Fix default stream flag value wrt matroska muxing

Hendrik Leppkes h.leppkes at gmail.com
Wed Jan 30 07:34:21 CET 2013


On Tue, Jan 29, 2013 at 10:02 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> On Monday 28 January 2013 12:55:09 pm Hendrik Leppkes wrote:
>> What i would do is check all input streams in the muxer (ie in
>> mkv_write_tracks),
>
>> and if none have a default disposition, then mark
>> the first of each type as such (first audio, first video, first
>> subtitle).
>
> This may be sensible, but is imo unrelated.
>
>> But if one stream is marked as default, then keep that
>> flag, and write it as 0 for all other streams.
>
> Done in attached patch, thank you for the suggestion!
>

Maybe it would be better to always write 0, even if no default exists?
Otherwise all streams are marked as default because of the implicit
default flag if its not written, not sure thats desirable?

I'll leave that to you, the solution looks otherwise good to me, no
side-effects bleeding into other parts of avformat, which was my main
concern.


More information about the ffmpeg-devel mailing list