[FFmpeg-devel] [PATCH] rename have_incompatible_fork_abi-> have_incompatible_libav_abi

[Michael Niedermayer]

On Tue, Jul 02, 2013 at 09:38:02AM +0200, Stefano Sabatini wrote:
> On date Monday 2013-07-01 18:51:06 -0700, Timothy Gu encoded:
> > On Jul 1, 2013 6:24 PM, "Carl Eugen Hoyos" <cehoyos at ag.or.at> wrote:
> > >
> > > Stefano Sabatini <stefasab <at> gmail.com> writes:
> > >
> > > > -#if AV_HAVE_INCOMPATIBLE_FORK_ABI
> > > > +#if AV_HAVE_INCOMPATIBLE_LIBAV_ABI
> > >
> 
> > > I consider AV_HAVE_INCOMPATIBLE_AVCONV_ABI
> 
> avconv is just one of the binaries included in Libav, why is it
> special (especially as we talk about libraries)?
> 
> > > less ambiguous.
> > 
> > Or
> > 
> > AV_HAVE_INCOMPATIBLE_LIBAV_FORK_ABI
> > 
> > or AV_HAVE_INCOMPATIBLE_FORK_LIBAV_ABI
> > 
> 
> > They all the original project name which I consider as a important issue.
> 
> +1.
> 
> > Also it would be better to extend it as there is a probability that
> > multiple incompatible forks to present.
> 
> Patch updated with more compat ugliness, kept the short form
> (incompatible_libav_abi) for simplicity.
> -- 
> FFmpeg = Formidable & Faithful Magnificient Patchable Enlightened Gymnast

>  configure               |    8 ++++++++
>  libavcodec/avcodec.h    |    2 +-
>  libavcodec/imgconvert.c |    2 +-
>  libavcodec/vdpau.h      |    4 ++--
>  libavutil/pixfmt.h      |    2 +-
>  5 files changed, 13 insertions(+), 5 deletions(-)
> c491b0187fdc4aa25deeeed32a4e62c520345759  0001-rename-have_incompatible_fork_abi-have_incompatible_.patch
> From 160295826f9d9a177efd8ab57f8ab4f12dbea59f Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefasab at gmail.com>
> Date: Mon, 1 Jul 2013 18:47:09 +0200
> Subject: [PATCH] rename have_incompatible_fork_abi ->
>  have_incompatible_libav_abi
> 
> "Fork" is an ambiguous term, since there may be more than one fork, also
> "fork" could be confused with the corresponding function. Also it seems
> important to point the name of the fork in the symbol.
> 
> Note: the old --enable-incompatible-fork-abi is retained for
> compatibility, although it should be considered deprecated.
> ---
>  configure               | 8 ++++++++
>  libavcodec/avcodec.h    | 2 +-
>  libavcodec/imgconvert.c | 2 +-
>  libavcodec/vdpau.h      | 4 ++--
>  libavutil/pixfmt.h      | 2 +-
>  5 files changed, 13 insertions(+), 5 deletions(-)
> 
> diff --git a/configure b/configure
> index dbb6672..4507bb8 100755
> --- a/configure
> +++ b/configure

> @@ -102,6 +102,8 @@ Configuration options:
>    --enable-gray            enable full grayscale support (slower color)
>    --disable-swscale-alpha  disable alpha channel support in swscale
>    --disable-all            disable building components, libraries and programs
> +  --enable-incompatible-libav-abi enable incompatible Libav fork ABI, only useful for packagers [no]
> +  --enable-incompatible-fork-abi  enable incompatible Libav fork ABI (deprecated), only useful for packagers [no]

its not just usefull for packagers
a debian or ubuntu user might want to build shared libs from ffmpeg
that would be used by installed packages (which where build against
libav)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130702/6ca58535/attachment.asc>