[FFmpeg-devel] [PATCH] lavfi/trim: use AV_OPT_TYPE_DURATION

Stefano Sabatini stefasab at gmail.com
Thu Jul 11 00:58:20 CEST 2013


On date Wednesday 2013-07-10 15:08:58 -0400, Derek Buitenhuis encoded:
> On 7/10/2013 2:27 PM, Paul B Mahol wrote:
> > This fixes one of major flaws.
> 
> Please documented which flaws these are in the
> commit message.
> 
> > Signed-off-by: Paul B Mahol <onemda at gmail.com>
> > ---
> >  doc/filters.texi   | 48 ++++++++++++++++++++++++++++++++++++++++++------
> >  libavfilter/trim.c | 24 ++++++++++++------------
> >  2 files changed, 54 insertions(+), 18 deletions(-)
> 
> [...]
> 
> > -Timestamp (in seconds) of the start of the kept section. I.e. the audio sample
> > +Specify time of the start of the kept section. I.e. the audio sample
> 
> "Specifies the starting time of section to keep. i.e. the audio sample
> ('i.e.' is ALWAYS lower case)

No we use the impersonal form since the Great Silly Holly Nerdy Third
Person War, now let's stick to it please.

Note: "i.e. ..." should be part of the same sentence.
> 
> >  with the timestamp @var{start} will be the first sample in the output.
> > +The accepted syntax is:
> > + at example
> > +[-]HH[:MM[:SS[.m...]]]
> > +[-]S+[.m...]
> > + at end example
> > +See also the function @code{av_parse_time()}.
> 

> Do we not have one place to document "duration" format? Seems silly
> to restate it for every filter.

Yes I think "duration specification" should be enough, keeping updated
sparse specification always fails badly.

[...]
-- 
FFmpeg = Frenzy Fanciful Moronic Portentous Erroneous Gospel


More information about the ffmpeg-devel mailing list