[FFmpeg-devel] [PATCH 3/5] ff_network_wait_fd_timeout(): check for interrupt before operation

Lukasz M lukasz.m.luki at gmail.com
Thu Jul 11 01:33:42 CEST 2013

>>> Yes, this way data won't be transmitted even if socket is readable
>>> (writable). So what? Abortion is requested from upper layers, this
>>> fact has top priority.
>> Maybe we have different use cases in mind, but what is the reason to
>> call read/write operation when this operation will never happen,
>> because it will be interrupted before try?
> The patched procedure is not used straightly by user, but by
> libavformat internal routines, including (indirectly) muxers, demuxers
> etc. These internal routines of libavformat may not be checking
> interrupt callback.
> So in conflict of interests - user wants to terminate blocking
> operation, and e.g. demuxer wants to get data - user is top priority.

Ok, I see you point i think. The issue is there is no way to use
protocol in non blocking mode. The operation is aborted before try.
Anyway, in case maintainers decide to merge it, function's doxy should
be updated too.

Best regards,
Lukasz Marek

More information about the ffmpeg-devel mailing list