[FFmpeg-devel] [PATCH]Fix pix_fmt detection in jpeg2000

Carl Eugen Hoyos cehoyos at ag.or.at
Wed Jul 17 09:15:09 CEST 2013

Nicolas Bertrand <nicoinattendu <at> gmail.com> writes:

> Le 16/07/2013 18:28, Carl Eugen Hoyos a écrit :
> > Attached patch combines the earlier two patches to 
> > improve jpeg2000 pix_fmt detection, it is necessary 
> > to fix all yuvxxx samples.

> The patch looks good, but I'm not comfortable with 
> YUV input.

> In case of YUV input the MCT shall be avoided (as it 
> transform YUV/YCbCr to RGB). Are we sure that YUV 
> samples deactive the MCT? ie in get_cod() tmp.mct 
> shall be 0.

I am not sure I understand.
tmp.mct is read from the file and only used if three 
or more components are available.
Do you mean that tmp.mct should be ignored for yuv 
files? Wouldn't that break decoding of funnily 
encoded files? Or does the specification mention 
that tmp.mct has to be ignored for colour_spaces 
!= rgb?

Thank you for the review!

Carl Eugen

More information about the ffmpeg-devel mailing list