[FFmpeg-devel] [PATCH] Joining a SSM multicast group using an SDP (Issue #2171)
michaelni at gmx.at
Thu Jul 18 18:07:41 CEST 2013
On Thu, Jun 27, 2013 at 08:53:00AM +0100, Ed Torbett wrote:
> Attached is a patch to resolve trac issue #2171 – Joining a SSM multicast group using an SDP.
> This reads the SDP parameter specifying the source-specific multicast settings and passes that information through the RTP protocol to the underlying UDP transport protocol (where code to join source-specific multicast groups already exists). It also verifies the source address of each received RTP packet (as otherwise packets from multiple sources are processed when multiple multicast groups are joined on the same server, such as when running multiple instances of ffmpeg).
> Please excuse any mistakes I’ve made in following the patching procedure, I will correct and resubmit as necessary.
> Signed-off-by: Edward Torbett <ed.torbett at simulation-systems.co.uk>
> From 971138cbce2c2871c81464023fe2ffc346a0e54f Mon Sep 17 00:00:00 2001
> From: Edward Torbett <ed.torbett at simulation-systems.co.uk>
> Date: 26-Jun-2013 15:53:24
> Passes Source-Specific Multicast parameters read from an sdp file through to the UDP socket code, allowing source-specific multicast streams to be correctly received. As an integral part of this change, additional checking (currently only enabled in the case of SSM streams, but probably useful in similar scenarios) has been added to the RTP protocol handler to distinguish UDP packets arriving from multiple sources to the same port and process only the expected packets (those transmitted from the expected UDP source address). This resolves an issue identified when multiple instances of FFMpeg subscribe to different Source-Specific Multicast streams but with each sharing the same destination port. Signed-off-by: Edward Torbett <ed.torbett at simulation-systems.co.uk>
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel